Open
Conversation
yash97
reviewed
Feb 6, 2026
|
|
||
| // Add IPv6 disable sysctls when DISABLE_POD_V6 is enabled | ||
| if disablePodV6 { | ||
| sysctls["net.ipv6.conf.all.disable_ipv6"] = "1" |
Contributor
There was a problem hiding this comment.
why do we need to explicitly add these?
Contributor
Author
There was a problem hiding this comment.
Because VPC CNI currently use tuning CN plugin to disable ipv6. This is just keeping that feature
Contributor
Author
There was a problem hiding this comment.
i wonder if i need to move this lower and override any tuning configs
yash97
reviewed
Feb 6, 2026
|
|
||
| Example: | ||
| ``` | ||
| TUNING_SYSCTLS='{"net.core.somaxconn":"1024","net.ipv4.tcp_max_syn_backlog":"2048"}' |
Contributor
There was a problem hiding this comment.
TOL does user have to provide value through env var? what will be experience if we had config map?
Contributor
Author
There was a problem hiding this comment.
This wasn't completely sure about. I was thinking env var however config map could work too however I didn't want to add a whole new config map just for this because it seems over kill
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix?:
#3586
What does this PR do / Why do we need it?:
Testing done on this change:
Will this PR introduce any new dependencies?:
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
Yes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.