Fix SMUS compatibility: fallback role resolution and example workflow path alignment#71
Fix SMUS compatibility: fallback role resolution and example workflow path alignment#71
Conversation
| @@ -27,18 +27,17 @@ stages: | |||
| dev: | |||
| stage: DEV | |||
| domain: | |||
There was a problem hiding this comment.
the domain name will be specific to individual use cases and hence our examples, which run as git hub actions, utilize tag based lookup. I would prefer to continue with the tag based lookup for the examples in the repo.
There was a problem hiding this comment.
sorry thats not an intended change. I forgot to revert my specific use case changes before committing.
| retries: 0 | ||
| job_name: setup-covid-db-job | ||
| script_location: '{proj.connection.default.s3_shared.s3Uri}dashboard-glue-quick/bundle/glue_setup_covid_db.py' | ||
| script_location: '{proj.connection.default.s3_shared.s3Uri}etl-scripts/bundle/glue_setup_covid_db.py' |
There was a problem hiding this comment.
Curious, why are we changing the bundle path name?
There was a problem hiding this comment.
the script already lies in dashboard-glue-quick folder in the repo, manifest file pointing to this folder duplicates the folder name
| typer.echo(f"✅ DEBUG: Found userRoleArn={role_arn}") | ||
| return role_arn | ||
|
|
||
| # Fallback: Get role from project owners (for SMUS compatibility) |
There was a problem hiding this comment.
can't we use this in the manifest instead? Why do we need this fallback in the code?
There was a problem hiding this comment.
i just tried to fix in a less interfering way.Ideally it should be the project_role only.
2 participants
What Changed
Added role resolution fallback logic for SMUS projects when tooling environment role discovery does not return a usable ARN.
Improved project membership handling to correctly derive owner-based role data for SMUS scenarios.
Aligned the example analytics workflow packaging and script path references so deployed workflow tasks resolve ETL scripts consistently.
Validation
Confirmed workflow creation now proceeds with fallback role resolution in SMUS.