Add CRD breaking change detection presubmit job#825
Open
a-hilaly wants to merge 1 commit intoaws-controllers-k8s:mainfrom
Open
Add CRD breaking change detection presubmit job#825a-hilaly wants to merge 1 commit intoaws-controllers-k8s:mainfrom
a-hilaly wants to merge 1 commit intoaws-controllers-k8s:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds a new presubmit job (crd-compat-check) to all service controllers and runtime. The job builds `ack-generate` from code-generator and runs its new crd-compat-check command, which compares CRD schemas on disk against the base branch using kro's CRD compatibility library. The job triggers only when CRD files change (`config/crd/` or `helm/crds/`) and blocks merge if breaking changes are detected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new presubmit job (crd-compat-check) to all service controllers
and runtime. The job builds
ack-generatefrom code-generator and runsits new crd-compat-check command, which compares CRD schemas on disk
against the base branch using kro's CRD compatibility library.
The job triggers only when CRD files change (
config/crd/orhelm/crds/)and blocks merge if breaking changes are detected.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.