Skip to content

Shared code for create/patch resources with wait on condition#824

Open
gustavodiaz7722 wants to merge 1 commit intoaws-controllers-k8s:mainfrom
gustavodiaz7722:refactor
Open

Shared code for create/patch resources with wait on condition#824
gustavodiaz7722 wants to merge 1 commit intoaws-controllers-k8s:mainfrom
gustavodiaz7722:refactor

Conversation

@gustavodiaz7722
Copy link
Contributor

@gustavodiaz7722 gustavodiaz7722 commented Feb 18, 2026

Issue #, if available:

Description of changes:

  • Common behavior found in ACK controller testing is first creating/patching resource and then polling for resource to reach condition.
  • This change defines above behavior into shared utility function that can be used to refactor duplicate code across all controllers.
  • Tested changes locally by updating quicksight controller integration test to use shared functions. All test passing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested a review from a-hilaly February 18, 2026 01:58
@ack-prow
Copy link

ack-prow bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gustavodiaz7722
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested a review from jlbutler February 18, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant