fix: always remove guestIdentityId from keyValueStorage on client-side#14437
Open
adrianjoshua-strutt wants to merge 4 commits intomainfrom
Open
fix: always remove guestIdentityId from keyValueStorage on client-side#14437adrianjoshua-strutt wants to merge 4 commits intomainfrom
adrianjoshua-strutt wants to merge 4 commits intomainfrom
Conversation
soberm
previously approved these changes
Jun 19, 2025
ahmedhamouda78
previously approved these changes
Jun 19, 2025
sarayev
previously approved these changes
Jun 19, 2025
pranavosu
requested changes
Jun 19, 2025
packages/auth/src/providers/cognito/credentialsProvider/IdentityIdStore.ts
Outdated
Show resolved
Hide resolved
pranavosu
reviewed
Jun 19, 2025
packages/auth/src/providers/cognito/credentialsProvider/IdentityIdStore.ts
Outdated
Show resolved
Hide resolved
baf70be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Using SSR the guest token in the cookies does not get removed on login. This is because
storeIdentityIdis called on the server-side before it is called on the client-side, thereby setting_hasGuestIdentityIdto false and hindering the client-side to remove the cookie in the browser.We do not always want to remove the guest identity cookie, because we want to prevent unnecessary cookie deletions when switching between identity types or during credential refreshes. (synced about this with @HuiSF - see #13787)
We fix this by
Issue
#14378
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.