Skip to content

Fix MACE fitting#470

Closed
JaGeo wants to merge 26 commits intomainfrom
2026_improve_fitting
Closed

Fix MACE fitting#470
JaGeo wants to merge 26 commits intomainfrom
2026_improve_fitting

Conversation

@JaGeo
Copy link
Copy Markdown
Collaborator

@JaGeo JaGeo commented Jan 7, 2026

Unfortunately, the MACE fitting procedure was broken in the previous version. It only considered energies and forces. See #469 for more details on one of the issues.

This PR should fix the issue. As we haven't produced any production data with this fitting module, this is not an issue for us.

@naik-aakash naik-aakash added the bug Something isn't working label Feb 1, 2026
@naik-aakash naik-aakash added the enhancement New feature or request label Feb 1, 2026
@JaGeo
Copy link
Copy Markdown
Collaborator Author

JaGeo commented Feb 25, 2026

I would like to merge this fast. However, my feeling is that it would be good to, in general, test the fitting modules systematically.

Common use cases:

  • use a previous database split in train/test, perform fit
  • use a previous database already split into train/test, perform fit
  • additional data clearning or selection needs to be performed.

@JaGeo
Copy link
Copy Markdown
Collaborator Author

JaGeo commented Feb 27, 2026

For now, I will continue in #483 . This PR attempted to much by also restructuring the fitting module imports.

@JaGeo JaGeo closed this Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants