ISSUE-730 # Implement timeout property for load testing#731
Open
mykhailo-qdxp wants to merge 3 commits intoauthorjapps:masterfrom
Open
ISSUE-730 # Implement timeout property for load testing#731mykhailo-qdxp wants to merge 3 commits intoauthorjapps:masterfrom
mykhailo-qdxp wants to merge 3 commits intoauthorjapps:masterfrom
Conversation
authorjapps
requested changes
Dec 21, 2025
| numberOfThreads = parseInt(properties.getProperty("number.of.threads")); | ||
| rampUpPeriod = parseInt(properties.getProperty("ramp.up.period.in.seconds")); | ||
| loopCount = parseInt(properties.getProperty("loop.count")); | ||
| abortAfterTimeLapsedInSeconds = parseInt(properties.getProperty("abort.after.time.lapsed.in.seconds")); |
Owner
There was a problem hiding this comment.
@mykhailo-qdxp , thanks for the PR. Can you ensure abortAfterTimeLapsedInSeconds is an optional property?
Collaborator
There was a problem hiding this comment.
@mykhailo-qdxp thanks for doing this, Can you try to cover via a Unit test to make sure backward compatibility is maintained (even if this property is not supplied or not present in the config, tests will still run fine)?
This will also ensure existing users are not affected(not broken their test suites when they switch to new version -- when released I mean)
If you've already taken care, just explain the flow, otherwise implement it please.
Thanks for understanding!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement timeout property for load testing
Fixed Which Issue?
Load tests property is not implemented #730
PR Branch
https://github.com/mykhailo-qdxp/zerocode/tree/issue-730
Motivation and Context
The configuration property
abort.after.time.lapsed.in.secondswas declared in configuration and documentation but never implemented. This change implements the property by terminating test runs after the specified elapsed time and throwing aRuntimeError, preventing indefinite stalls.Checklist:
1. New Unit tests were added
2. Integration tests were added
3. Test names are meaningful
3.1 Feature manually tested and outcome is successful
4. PR doesn't break any of the earlier features for end users
5. PR doesn't break the HTML report features directly
/targetfolder and they look fine6. PR doesn't break any HTML report features indirectly
7. Branch build passed in CI
8. No 'package.*' in the imports
9. Relevant DOcumentation page added or updated with clear instructions and examples for the end user
10. Http test added to
http-testing-examplesmodule(if applicable) ?11. Kafka test added to
kafka-testing-examplesmodule(if applicable) ?