Reducing the amount of information read from the table file for variant types#379
Open
amblafont wants to merge 1 commit intoau-ts:masterfrom
Open
Reducing the amount of information read from the table file for variant types#379amblafont wants to merge 1 commit intoau-ts:masterfrom
amblafont wants to merge 1 commit intoau-ts:masterfrom
Conversation
This reduced piece of information seems to be enough (thinking of the upcoming new table format).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sum constructor of uval (in ML) only needs a list of booleans (indicating whether each constructor is checked) rather than the full list of the types of the constructors.
I trust the ML typechecker, so I don't expect any bad outcome of testing bilby with this change. I would let @vjackson725 perform the test, as the README file for bilby scares me :)