Conversation
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
What reviewer looks at during PR reviewThe following are ideal points maintainers look for during review. Reviewing these points yourself beforehand can help streamline the review process and reduce time to merge.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdated README.md with three non-functional text fixes: "basing on" → "based on" in the Generator description, "undestand" → "understands" in the React-sdk description, and "Developement guide" → "Development guide" in the Contributing section. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
README.md (1)
9-9: Optional: Fix subject-verb agreement.The phrase "the library that understand" should use "understands" for proper subject-verb agreement with the singular noun "library."
📝 Suggested grammar improvement
-1. [React-sdk](apps/react-sdk): AsyncAPI React SDK is a set of components/functions to use React as render engine for the generator. This is the library that understand components from Generator's templates that are configured to use `react` render engine. +1. [React-sdk](apps/react-sdk): AsyncAPI React SDK is a set of components/functions to use React as render engine for the generator. This is the library that understands components from Generator's templates that are configured to use `react` render engine.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` at line 9, The README sentence "This is the library that understand components..." has a subject-verb agreement error; update the phrase in the React-sdk description (the sentence containing "the library that understand components from Generator's templates") to use "understands" instead of "understand" so it reads "the library that understands components from Generator's templates that are configured to use `react` render engine."
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@README.md`:
- Line 9: The README sentence "This is the library that understand
components..." has a subject-verb agreement error; update the phrase in the
React-sdk description (the sentence containing "the library that understand
components from Generator's templates") to use "understands" instead of
"understand" so it reads "the library that understands components from
Generator's templates that are configured to use `react` render engine."
Apply CodeRabbit suggestion: 'understand' → 'understands' for subject-verb agreement.
cairon-ab
requested review from
Florence-Njeri,
asyncapi-bot-eve and
derberg
as code owners
|
|
mention issue please |
3 participants
Description
Fixes several typos in the root
README.md:These are simple text corrections with no functional changes.
Summary by CodeRabbit