Adding query_all() to heasarc.

[trjaffe]

Rebased and squashed after the #3493 fiasco, which we can discard.

This includes comments made there, but the changes were confused so it needs review again.

[trjaffe]

@zoghbi-a I'm adding the extra angular offset column you requested. Each row in the result is a count of matching rows for that table, and I have added a distance computation into the query. But that's the distance for every matching row, and so we need to choose an aggregate in the SQL that makes the most sense here, like MAX() or AVG(). MAX makes sense when you do not specify a radius, because that means it's using a different radius for each catalog and you otherwise don't see any indication of that in the results. If you do specify a radius, then I'm not sure there's anything useful to aggregate about the angular offset. Did you have a use case in mind that helps?

[codecov]

Codecov Report

❌ Patch coverage is 77.33333% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.97%. Comparing base (85e64c5) to head (dd74637).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
astroquery/heasarc/core.py	77.33%	17 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3499      +/-   ##
==========================================
+ Coverage   71.95%   71.97%   +0.01%     
==========================================
  Files         235      235              
  Lines       20328    20403      +75     
==========================================
+ Hits        14627    14685      +58     
- Misses       5701     5718      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[trjaffe]

@bsipocz Would you please take another look at this sometime? I have fixed a bunch of things and learned to love git pre-commit hooks. There are still some test failures but not in the parts of the code I have changed AFAIK.

[bsipocz]

@trjaffe - do you consider this ready for review or still as a draft?

[trjaffe]

@trjaffe - do you consider this ready for review or still as a draft?

I think it's pretty close to done, so no longer a draft, yes, ready for review.