res_pjsip: Redirect module and handling for MESSAGEs #1580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cherry-pick-to: 20 |
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
|
Workflow PRCheck completed successfully |
maximilianfridrich
force-pushed
the
pjsip_redirect_module
branch
from
683e974 to
788d3d7
Compare
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-tests-passed
pr-submit-testing-in-progress
labels
|
Workflow PRCheck completed successfully |
maximilianfridrich
force-pushed
the
pjsip_redirect_module
branch
from
788d3d7 to
f07f2e0
Compare
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-tests-passed
pr-submit-testing-in-progress
labels
|
Workflow PRCheck completed successfully |
jcolp
requested changes
Nov 25, 2025
maximilianfridrich
force-pushed
the
pjsip_redirect_module
branch
from
f07f2e0 to
cd6d080
Compare
github-actions
bot
added
pr-submit-testing-in-progress
and removed
pr-submit-tests-passed
labels
Contributor
Author
|
Thanks for the review @jcolp! I've incorporated your feedback and responded to your comments. Let me know what you think. |
github-actions
bot
added
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
|
Workflow PRCheck completed successfully |
jcolp
requested changes
Dec 8, 2025
maximilianfridrich
force-pushed
the
pjsip_redirect_module
branch
from
cd6d080 to
c39a0bb
Compare
github-actions
bot
added
pr-submit-testing-in-progress
and removed
pr-submit-tests-passed
labels
This commit introduces a new redirect handling module that provides infrastructure for following SIP 3xx redirect responses. The redirect functionality respects the endpoint's redirect_method setting and only follows redirects when set to 'uri_pjsip'. This infrastructure can be used by any PJSIP module that needs to handle 3xx redirect responses.
This commit integrates the redirect module into res_pjsip_messaging to enable following 3xx redirect responses for outgoing SIP MESSAGEs. When follow_redirect_methods contains 'message' on an endpoint, Asterisk will now follow 3xx redirect responses for MESSAGEs, similar to how it behaves for INVITE responses. Resolves: asterisk#1576 UserNote: A new pjsip endpoint option follow_redirect_methods was added. This option is a comma-delimited, case-insensitive list of SIP methods for which SIP 3XX redirect responses are followed. An alembic upgrade script has been added for adding this new option to the Asterisk database.
maximilianfridrich
force-pushed
the
pjsip_redirect_module
branch
from
f55d813 to
37f4f0f
Compare
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-tests-passed
pr-submit-testing-in-progress
labels
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
has-pr-checklist
|
Workflow PRCheck completed successfully |
gtjoseph
dismissed
github-actions[bot]’s stale review
Pull Request Checklist Complete
github-actions
bot
added
cherry-pick-testing-in-progress
|
Workflow PRCPCheck completed successfully |
github-actions
bot
added
pre-merge-testing-in-progress
pre-merge-checks-passed
merge-in-progress
and removed
merge-approved
pre-merge-testing-in-progress
labels
|
Successfully merged to branch master and cherry-picked to ["20","22","23"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
res_pjsip: Introduce redirect module for handling 3xx responses
This commit introduces a new redirect handling module that provides
infrastructure for following SIP 3xx redirect responses. The redirect
functionality respects the endpoint's redirect_method setting and only
follows redirects when set to 'uri_pjsip'. This infrastructure can be
used by any PJSIP module that needs to handle 3xx redirect responses.
res_pjsip_messaging: Add support for following 3xx redirects
This commit integrates the redirect module into res_pjsip_messaging
to enable following 3xx redirect responses for outgoing SIP MESSAGEs.
When follow_redirect_methods contains 'message' on an endpoint, Asterisk
will now follow 3xx redirect responses for MESSAGEs, similar to how
it behaves for INVITE responses.
Resolves: #1576
UserNote: A new pjsip endpoint option follow_redirect_methods was added.
This option is a comma-delimited, case-insensitive list of SIP methods
for which SIP 3XX redirect responses are followed. An alembic upgrade
script has been added for adding this new option to the Asterisk
database.