Conversation
* Remove zoom-dependent rescaling * Don't redraw on each render; just update highlight if necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigation
Solution
sharplibrary. These are called "renditions", i.e. a single image asset can have multiple renditions. Renditions can vary in size, resolution, or format, but they are always different versions of the same image.ItemThumbnailController.ItemRenderer. This renderer also optionally renders an icon overlay on top of the thumbnail.display: noneis not used, because it leads to undesired flashes in some cases.TapestryElementRenderer. Now each renderer extracts a "render state" from the view model on each frame and only re-renders if the render state differs.Further improvements