Conversation
Sachanski
previously approved these changes
Dec 19, 2025
Collaborator
Sachanski
left a comment
Sachanski
left a comment
There was a problem hiding this comment.
No changes needed on the backend when importing, right?
| setShowModal(false) | ||
| dispatch(updateItem(dto.id, { dto: { action } })) | ||
| const actionType = determineActionType(url, tapestryPath, tapestryId) | ||
| const action = extractAction(url, actionType) |
Collaborator
There was a problem hiding this comment.
I don't mind the separate functions, but it seems they can be a single function seeing how the output from the first is fed as an input to the second, but as I already said - keeping them separate is perfectly fine as well, more flexible even.
| interactiveElement?.modelId !== pointerInteraction.target.modelId | ||
|
|
||
| if (isHoveringInactiveElement) { | ||
| cursor = 'pointer' |
Collaborator
There was a problem hiding this comment.
So this is where that one went...
Sachanski
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scene-cursorclass was not defined in the viewer).