Skip to content

fix: correct test expectation for first aggregate with include_nil? #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachdaniel merged 1 commit into from
Feb 4, 2026
Merged

fix: correct test expectation for first aggregate with include_nil? #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/aggregate_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,7 @@
end

@tag :postgres_16
test "it returns `nil` values when `include_nil?` is `true`" do

Check failure on line 861 in test/aggregate_test.exs

View workflow job for this annotation

GitHub Actions / ash-ci (16) / mix test 

test first it returns `nil` values when `include_nil?` is `true` (AshSql.AggregateTest)
post =
Post
|> Ash.Changeset.for_create(:create, %{title: "title"})
Expand All @@ -874,7 +874,9 @@
|> Ash.Changeset.manage_relationship(:post, post, type: :append_and_remove)
|> Ash.create!()

assert "match" ==
# With sort(title: :asc_nils_first), nil comes first.
# With include_nil?: true, we should get nil (not skip to the next non-nil value)
assert nil ==
Post
|> Ash.Query.filter(id == ^post.id)
|> Ash.Query.load(:first_comment_nils_first_include_nil)
Expand Down
Loading