feat: Derive Eq, PartialEq where possible#865
Draft
appellation wants to merge 2 commits intoarlyon:masterfrom
Draft
feat: Derive Eq, PartialEq where possible#865appellation wants to merge 2 commits intoarlyon:masterfrom
appellation wants to merge 2 commits intoarlyon:masterfrom
Conversation
|
@appellation is attempting to deploy a commit to the arlyon Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Great idea, I have added the appropriate linguist directives. Learned something new about GH today. CI approved, TY! You may need to rebase to have them applied to your diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #727
This diff is unfortunately very unwieldy since quite a few structs now implement Eq and PartialEq. The best way to review this is by looking at the first commit only. (Side note, would it be reasonable to mark Rust files in
generated/as generated files so that GitHub hides their diffs by default?)Checklist
cargo make fmt