changed version protocol number from unsigned to signed int #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Is this something modded servers do? If so, lgtm. This is an API-breaking change so I'll think about if I want to bundle this with anything else before shipping 3.0 :) |
Contributor
Author
|
That happens on servers if they support multiple versions i think. From my testing not all of them so i guess it depends on what they use to support multiple versions. One server where that happens is horizonanarchy.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While i was using that i noticed that if a server returns -1 as the protocol version like some servers do, you get an invalid status response error. This should fix that.