-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore: remove Python SDK #14995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: remove Python SDK #14995
Conversation
The Python SDK has been deprecated and replaced by Hera (https://github.com/argoproj-labs/hera). This commit removes: - sdks/python/ directory containing the entire Python SDK - Python SDK build and test configuration from CI/CD workflows - Python SDK generation from the Makefile - Python SDK references from git configuration files Documentation has been updated to emphasize Hera as the recommended Python SDK for Argo Workflows, with Hera now listed alongside Java and Golang in the client libraries table. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Alan Clucas <[email protected]>
Update generated docs/README.md to reflect changes in main README.md. This file is automatically generated by hack/docs/copy-readme.sh during the make docs process. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Alan Clucas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated Python SDK from the Argo Workflows repository. The Python SDK was deprecated in version 3.6 and has been superseded by Hera (https://github.com/argoproj-labs/hera). The changes eliminate the entire sdks/python/ directory containing the SDK implementation, along with associated build configurations, CI/CD workflows, and git configuration files.
Reviewed Changes
Copilot reviewed 59 out of 853 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdks/python/client/argo_workflows/model/*.py | Removed auto-generated model classes for the Python SDK |
| sdks/python/client/argo_workflows/exceptions.py | Removed exception handling classes for the SDK |
| sdks/python/client/argo_workflows/api/init.py | Removed API module initialization file |
| sdks/python/client/argo_workflows/model/init.py | Removed model module initialization file |
| sdks/python/.gitignore | Removed Python SDK-specific gitignore configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ad9d936 to
e78a14e
Compare
Document the removal of the Python SDK in version 4.0 and clarify that while the SDK is no longer provided or supported, existing installations will mostly continue to work. Provide migration guidance to Hera for users who wish to migrate to a supported Python SDK. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Alan Clucas <[email protected]>
e78a14e to
18076ea
Compare
chansuke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
gianarb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Since I am new to the codebase let me write a note about how I looked at this PR.
I started looking at the tree of changed files. I looked at the one outside the sdk/python folder to figure out what the changes.
it looks good to me!
Closes #14159
The Python SDK has been deprecated since 3.6 and replaced by Hera (https://github.com/argoproj-labs/hera). This commit removes:
Documentation has been updated to emphasize Hera as the recommended Python SDK for Argo Workflows, with Hera now listed alongside Java and Golang in the client libraries table.