Skip to content

Conversation

@mikeshng
Copy link
Contributor

@mikeshng mikeshng commented Dec 3, 2025

Fixes [ISSUE #25498]

The ClusterDecisionResourceGenerator was missing cluster secret metadata (labels and annotations) that the ClusterGenerator already provides. This PR adds fixes this issue by fetching cluster secrets and including metadata.labels.key and metadata.annotations.key params for each matched cluster, following the same pattern used by ClusterGenerator.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@mikeshng mikeshng requested review from a team as code owners December 3, 2025 17:49
@bunnyshell
Copy link

bunnyshell bot commented Dec 3, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@mikeshng
Copy link
Contributor Author

mikeshng commented Dec 3, 2025

FYI @ch-stark

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.47%. Comparing base (7cdc0f9) to head (a4fba8e).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
applicationset/generators/duck_type.go 80.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #25499      +/-   ##
==========================================
+ Coverage   62.45%   62.47%   +0.01%     
==========================================
  Files         351      351              
  Lines       49490    49520      +30     
==========================================
+ Hits        30910    30936      +26     
- Misses      15621    15622       +1     
- Partials     2959     2962       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant