Do not overwrite loaded tools in cluster benchmarks when verbose#1334
Do not overwrite loaded tools in cluster benchmarks when verbose#1334aprokop merged 1 commit intoarborx:masterfrom
Conversation
dalg24
left a comment
There was a problem hiding this comment.
If we go that route, then technically the ArborXBenchmark::{push,pop}_region symbols do not need to be exposed (we could remove them from our headers and define them in an anonymous namespace).
Thoughts on making it a try_set_timer_hooks() -> bool and repeat the warning (we might want to use raw string literals)
One reason I did not eliminate those as I didn't want to populate the global namespace. I suppose I can put them in the anonymous namespace instead.
We can. |
f3f99a2 to
90cb3be
Compare
|
@dalg24 I updated the code to follow your suggestions. |
90cb3be to
97b4bc9
Compare
97b4bc9 to
4f3a051
Compare
The output looks like this: