Skip to content

Do not overwrite loaded tools in cluster benchmarks when verbose#1334

Merged
aprokop merged 1 commit intoarborx:masterfrom
aprokop:warn_loaded_kokkos_tools
Mar 7, 2026
Merged

Do not overwrite loaded tools in cluster benchmarks when verbose#1334
aprokop merged 1 commit intoarborx:masterfrom
aprokop:warn_loaded_kokkos_tools

Conversation

@aprokop
Copy link
Contributor

@aprokop aprokop commented Mar 5, 2026

The output looks like this:


        *** Warning: Kokkos profiling tools are already active, ignoring the the --verbose argument. ***

@aprokop aprokop requested a review from dalg24 March 5, 2026 16:52
Copy link
Contributor

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go that route, then technically the ArborXBenchmark::{push,pop}_region symbols do not need to be exposed (we could remove them from our headers and define them in an anonymous namespace).
Thoughts on making it a try_set_timer_hooks() -> bool and repeat the warning (we might want to use raw string literals)

@aprokop
Copy link
Contributor Author

aprokop commented Mar 5, 2026

If we go that route, then technically the ArborXBenchmark::{push,pop}_region symbols do not need to be exposed (we could remove them from our headers and define them in an anonymous namespace).

One reason I did not eliminate those as I didn't want to populate the global namespace. I suppose I can put them in the anonymous namespace instead.

Thoughts on making it a try_set_timer_hooks() -> bool and repeat the warning (we might want to use raw string literals)

We can. try would not be the right name, as the current behavior always overwrites the existing hooks. Maybe set_timer_hooks() -> bool?

@aprokop aprokop force-pushed the warn_loaded_kokkos_tools branch from f3f99a2 to 90cb3be Compare March 6, 2026 03:01
@aprokop
Copy link
Contributor Author

aprokop commented Mar 6, 2026

@dalg24 I updated the code to follow your suggestions.

@aprokop aprokop force-pushed the warn_loaded_kokkos_tools branch from 90cb3be to 97b4bc9 Compare March 6, 2026 14:26
@aprokop aprokop force-pushed the warn_loaded_kokkos_tools branch from 97b4bc9 to 4f3a051 Compare March 6, 2026 15:57
@aprokop aprokop requested a review from dalg24 March 6, 2026 17:01
@aprokop aprokop merged commit 025186b into arborx:master Mar 7, 2026
2 checks passed
@aprokop aprokop deleted the warn_loaded_kokkos_tools branch March 7, 2026 14:21
@aprokop aprokop changed the title Warn when rewriting loaded Kokkos tools for timers in cluster benchmarks Do not overwrite loaded tools in cluster benchmarks when verbose Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants