Skip to content

Cleanup some old FIXMEs#1333

Merged
aprokop merged 3 commits intoarborx:masterfrom
aprokop:cleanup_some_fixmes
Mar 6, 2026
Merged

Cleanup some old FIXMEs#1333
aprokop merged 3 commits intoarborx:masterfrom
aprokop:cleanup_some_fixmes

Conversation

@aprokop
Copy link
Contributor

@aprokop aprokop commented Mar 5, 2026

No description provided.

@aprokop
Copy link
Contributor Author

aprokop commented Mar 5, 2026

Removal of the DBSCAN verification fix still results in

<snip>/benchmarks/cluster/ArborX_DBSCANVerification.hpp:483:17: error: expected primary-expression before 'index'
  483 |   ArborX::DistributedTree index(comm, exec_space,
      |                 ^~~~~

issue with CUDA 12.0.1. We can try to upgrade our CUDA requirement to 12.2 and retry, or return the workaround. I think I prefer the former to align better with Kokkos 5.0.

@aprokop aprokop force-pushed the cleanup_some_fixmes branch from dfacd57 to a8b102b Compare March 5, 2026 21:06
@aprokop
Copy link
Contributor Author

aprokop commented Mar 5, 2026

OK, the distributed tree deduction guide does not work even with CUDA 12.8. So, dropping that patch.

@aprokop
Copy link
Contributor Author

aprokop commented Mar 6, 2026

Everything passes, some irrelevant warnings from container build.

@aprokop aprokop merged commit a65f3c6 into arborx:master Mar 6, 2026
1 of 2 checks passed
@aprokop aprokop deleted the cleanup_some_fixmes branch March 6, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants