Skip to content

Use SYCL::sycl_queue instead of implementation details#1332

Merged
aprokop merged 1 commit intoarborx:masterfrom
masterleinad:use_sycl_queue
Mar 3, 2026
Merged

Use SYCL::sycl_queue instead of implementation details#1332
aprokop merged 1 commit intoarborx:masterfrom
masterleinad:use_sycl_queue

Conversation

@masterleinad
Copy link
Collaborator

Fixes #1331.

@aprokop
Copy link
Contributor

aprokop commented Mar 3, 2026

Note to self: the original change using impl was introduced in #456 (05/2021). The syql_queue function in Kokkos was added in kokkos/kokkos#5241 (07/2022).

The Kokkos PR that broke thing: kokkos/kokkos#8878. We don't have nightly SYCL testing, so we didn't detect it.

The Kokkos' sort_by_key is already correct.

@aprokop aprokop merged commit 314241f into arborx:master Mar 3, 2026
1 of 2 checks passed
@aprokop aprokop deleted the use_sycl_queue branch March 3, 2026 02:26
@aprokop aprokop mentioned this pull request Mar 3, 2026
@dalg24
Copy link
Contributor

dalg24 commented Mar 3, 2026

Note that with #1302 we get rid of all that code. I am still hoping we can get it in for 2.1 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with SYCL / Kokkos and ArborX_KokkosExtSort.hpp

3 participants