Skip to content

Enable reverse dispatch for intersects and distance algos#1330

Closed
dalg24 wants to merge 2 commits intoarborx:masterfrom
dalg24:reverse_dispatch
Closed

Enable reverse dispatch for intersects and distance algos#1330
dalg24 wants to merge 2 commits intoarborx:masterfrom
dalg24:reverse_dispatch

Conversation

@dalg24
Copy link
Contributor

@dalg24 dalg24 commented Jan 18, 2026

Synthesize the reverse dispatch algo(geom2, geom1) and only require one specialization.

An attempt to resolve the issue Andrey reported about some combination of algo and geometries that we forgot to implement.

@aprokop
Copy link
Contributor

aprokop commented Jan 18, 2026

Thank you for working on this. Kinda funny that we did it at the same time.

This PR is an alternative to #1329. Instead of introducing is_complete_v concept, it introduces reverse apply. Very similar.

I don't really care which way we go. I do care that we grab updates to the intersects and distance and update the tests the way it is done in #1329.

@aprokop aprokop added the enhancement New feature or request label Jan 18, 2026
@dalg24
Copy link
Contributor Author

dalg24 commented Jan 18, 2026

I had not seen your PR until now :/
I think the advantage with the reverse dispatch helper is that we don't repeat the logic for each algorithm.

@aprokop
Copy link
Contributor

aprokop commented Jan 18, 2026

Would you mind if I just grab your reverse dispatch, put it in #1330 and close this one?

@dalg24
Copy link
Contributor Author

dalg24 commented Jan 18, 2026

Go ahead

@aprokop aprokop closed this Jan 19, 2026
@dalg24 dalg24 deleted the reverse_dispatch branch January 19, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants