Enable reverse dispatch for intersects and distance algos#1330
Closed
dalg24 wants to merge 2 commits intoarborx:masterfrom
Closed
Enable reverse dispatch for intersects and distance algos#1330dalg24 wants to merge 2 commits intoarborx:masterfrom
dalg24 wants to merge 2 commits intoarborx:masterfrom
Conversation
Contributor
|
Thank you for working on this. Kinda funny that we did it at the same time. This PR is an alternative to #1329. Instead of introducing I don't really care which way we go. I do care that we grab updates to the intersects and distance and update the tests the way it is done in #1329. |
Contributor
Author
|
I had not seen your PR until now :/ |
Contributor
|
Would you mind if I just grab your reverse dispatch, put it in #1330 and close this one? |
Contributor
Author
|
Go ahead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synthesize the reverse dispatch
algo(geom2, geom1)and only require one specialization.An attempt to resolve the issue Andrey reported about some combination of algo and geometries that we forgot to implement.