Update comments in fk_algorithm.rs to better explain circulant matrix evaluation

[rex1fernando]

Note

Low Risk
Comment-only changes; no impact to cryptographic logic or runtime behavior.

Overview
Updates the documentation for CirculantDomain::eval in fk_algorithm.rs to better explain circulant-matrix evaluation as polynomial convolution computed via FFT/iFFT, and refreshes the ASCII diagrams used in the comment.

No functional or API behavior changes; code remains the same.

^{Written by Cursor Bugbot for commit c2a4228. This will update automatically on new commits. Configure here.}

[github-actions]

✅ Forge suite compat success on f7584aaea312be8840db1ba2e97a961af7c54f87 ==> c2a4228bd3e8aaa7171afe02cd9a8d38d52d0921

Compatibility test results for f7584aaea312be8840db1ba2e97a961af7c54f87 ==> c2a4228bd3e8aaa7171afe02cd9a8d38d52d0921 (PR)
1. Check liveness of validators at old version: f7584aaea312be8840db1ba2e97a961af7c54f87
compatibility::simple-validator-upgrade::liveness-check : committed: 13569.83 txn/s, latency: 2565.65 ms, (p50: 2700 ms, p70: 2800, p90: 3000 ms, p99: 3400 ms), latency samples: 444500
2. Upgrading first Validator to new version: c2a4228bd3e8aaa7171afe02cd9a8d38d52d0921
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6054.62 txn/s, latency: 5579.64 ms, (p50: 6200 ms, p70: 6300, p90: 6500 ms, p99: 6600 ms), latency samples: 212320
3. Upgrading rest of first batch to new version: c2a4228bd3e8aaa7171afe02cd9a8d38d52d0921
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6192.72 txn/s, latency: 5470.34 ms, (p50: 6000 ms, p70: 6100, p90: 6500 ms, p99: 6700 ms), latency samples: 211260
4. upgrading second batch to new version: c2a4228bd3e8aaa7171afe02cd9a8d38d52d0921
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7393.99 txn/s, latency: 4333.40 ms, (p50: 3000 ms, p70: 3800, p90: 12000 ms, p99: 14400 ms), latency samples: 244340
5. check swarm health
Compatibility test for f7584aaea312be8840db1ba2e97a961af7c54f87 ==> c2a4228bd3e8aaa7171afe02cd9a8d38d52d0921 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on c2a4228bd3e8aaa7171afe02cd9a8d38d52d0921

two traffics test: inner traffic : committed: 13492.96 txn/s, latency: 2789.71 ms, (p50: 2700 ms, p70: 2900, p90: 3000 ms, p99: 3600 ms), latency samples: 5018620
two traffics test : committed: 99.98 txn/s, latency: 753.68 ms, (p50: 700 ms, p70: 800, p90: 900 ms, p99: 1100 ms), latency samples: 1640
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.282, avg: 2.212", "ConsensusProposalToOrdered: max: 0.169, avg: 0.166", "ConsensusOrderedToCommit: max: 0.049, avg: 0.043", "ConsensusProposalToCommit: max: 0.216, avg: 0.209"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.42s no progress at version 7460 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.29s no progress at version 542887 (avg 0.29s) [limit 16].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on f7584aaea312be8840db1ba2e97a961af7c54f87 ==> c2a4228bd3e8aaa7171afe02cd9a8d38d52d0921

Forge report malformed: Expecting ',' delimiter: line 37 column 1 (char 1076)
'{\n  "metrics": [\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "submitted_txn",\n      "value": 216361.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "expired_txn",\n      "value": 540.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_tps",\n      "value": 2387.2039063833117\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_latency",\n      "value": 1226.3604468517892\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p50_latency",\n      "value": 1200.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p90_latency",\n      "value": 1600.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p99_latency",\n      "value": 2100.0\n[2026-02-11T20:09:51Z INFO  aptos_forge::report] Test Ok\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "submitted_txn",\n      "value": 212800.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "expired_txn",\n      "value": 860.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_tps",\n      "value": 2349.754943280329\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_latency",\n      "value": 1241.5106586769841\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p50_latency",\n      "value": 1200.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p90_latency",\n      "value": 1500.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p99_latency",\n      "value": 2100.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "submitted_txn",\n      "value": 75180.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "expired_txn",\n      "value": 280.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_tps",\n      "value": 821.656873321847\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "avg_latency",\n      "value": 3575.73738317757\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p50_latency",\n      "value": 1200.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p90_latency",\n      "value": 11100.0\n    },\n    {\n      "test_name": "framework_upgrade::framework-upgrade::full-framework-upgrade",\n      "metric": "p99_latency",\n      "value": 11700.0\n    }\n  ],\n  "text": "Compatibility test results for f7584aaea312be8840db1ba2e97a961af7c54f87 ==> c2a4228bd3e8aaa7171afe02cd9a8d38d52d0921 (PR)\\nUpgrade the nodes to version: c2a4228bd3e8aaa7171afe02cd9a8d38d52d0921\\nframework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2387.20 txn/s, submitted: 2393.18 txn/s, failed submission: 5.97 txn/s, expired: 5.97 txn/s, latency: 1226.36 ms, (p50: 1200 ms, p70: 1200, p90: 1600 ms, p99: 2100 ms), latency samples: 215821\\nframework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2349.75 txn/s, submitted: 2359.29 txn/s, failed submission: 9.53 txn/s, expired: 9.53 txn/s, latency: 1241.51 ms, (p50: 1200 ms, p70: 1400, p90: 1500 ms, p99: 2100 ms), latency samples: 211940\\n5. check swarm health\\nCompatibility test for f7584aaea312be8840db1ba2e97a961af7c54f87 ==> c2a4228bd3e8aaa7171afe02cd9a8d38d52d0921 passed\\nUpgrade the remaining nodes to version: c2a4228bd3e8aaa7171afe02cd9a8d38d52d0921\\nframework_upgrade::framework-upgrade::full-framework-upgrade : committed: 821.66 txn/s, submitted: 824.73 txn/s, failed submission: 3.07 txn/s, expired: 3.07 txn/s, latency: 3575.74 ms, (p50: 1200 ms, p70: 1500, p90: 11100 ms, p99: 11700 ms), latency samples: 74900\\nTest Ok"\n}'
Trailing Log Lines:
Compatibility test results for f7584aaea312be8840db1ba2e97a961af7c54f87 ==> c2a4228bd3e8aaa7171afe02cd9a8d38d52d0921 (PR)
Upgrade the nodes to version: c2a4228bd3e8aaa7171afe02cd9a8d38d52d0921
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2387.20 txn/s, submitted: 2393.18 txn/s, failed submission: 5.97 txn/s, expired: 5.97 txn/s, latency: 1226.36 ms, (p50: 1200 ms, p70: 1200, p90: 1600 ms, p99: 2100 ms), latency samples: 215821
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2349.75 txn/s, submitted: 2359.29 txn/s, failed submission: 9.53 txn/s, expired: 9.53 txn/s, latency: 1241.51 ms, (p50: 1200 ms, p70: 1400, p90: 1500 ms, p99: 2100 ms), latency samples: 211940
5. check swarm health
Compatibility test for f7584aaea312be8840db1ba2e97a961af7c54f87 ==> c2a4228bd3e8aaa7171afe02cd9a8d38d52d0921 passed
Upgrade the remaining nodes to version: c2a4228bd3e8aaa7171afe02cd9a8d38d52d0921
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 821.66 txn/s, submitted: 824.73 txn/s, failed submission: 3.07 txn/s, expired: 3.07 txn/s, latency: 3575.74 ms, (p50: 1200 ms, p70: 1500, p90: 11100 ms, p99: 11700 ms), latency samples: 74900
Test Ok

=== BEGIN JUNIT ===
<?xml version="1.0" encoding="UTF-8"?>
<testsuites name="forge" tests="1" failures="0" errors="0" uuid="c47f6214-2f4c-4d81-87ee-637a407f3b99">
    <testsuite name="local" tests="1" disabled="0" errors="0" failures="0">
        <testcase name="framework_upgrade::framework-upgrade">
        </testcase>
    </testsuite>
</testsuites>
=== END JUNIT ===
[2026-02-11T20:09:51Z INFO  aptos_forge::backend::k8s::cluster_helper] Deleting namespace forge-framework-upgrade-pr-18586: Some(NamespaceStatus { conditions: None, phase: Some("Terminating") })
[2026-02-11T20:09:51Z INFO  aptos_forge::backend::k8s::cluster_helper] aptos-node resources for Forge removed in namespace: forge-framework-upgrade-pr-18586

test result: ok. 1 passed; 0 soft failed; 0 hard failed; 0 filtered out

Debugging output:
NAME                                         READY   STATUS      RESTARTS   AGE
aptos-node-0-validator-0                     1/1     Running     0          13m
aptos-node-1-validator-0                     1/1     Running     0          12m
aptos-node-2-validator-0                     1/1     Running     0          3m59s
aptos-node-3-validator-0                     1/1     Running     0          2m42s
forge-testnet-deployer-8nb9n                 0/1     Completed   0          17m
genesis-aptos-genesis-eforgef57c1092-w7jcs   0/1     Completed   0          17m

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking