Skip to content

Sync with Raccoongang#50

Open
dyudyunov wants to merge 5 commits intoappsembler:masterfrom
raccoongang:dyudyunov/sync-with-raccoongang
Open

Sync with Raccoongang#50
dyudyunov wants to merge 5 commits intoappsembler:masterfrom
raccoongang:dyudyunov/sync-with-raccoongang

Conversation

@dyudyunov
Copy link

Change description

  • Add translations support.
  • Remove brightcove.css to fix player control buttons duplication.
  • Minor fixes according to relocation to py3

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

sendr and others added 5 commits January 13, 2022 19:51
JuniperOeX-231 Video Xblock
- relocation to python3.5 for juniper release of open edX
- fixed tests
- dependencies changes

JuniperOeX-178 Translation support added to Video XBlock
- Added support for only own translations.
Changes:
- upgdate test requirements for xblock-sdk
- upgrade XBlock dep to 1.4.0
- try with original pycaption==1.0.7 package
- use pycaption==1.0.7 due to pinned lxml>=4.6.3
Changes:
- unpin XBlock from 1.4.0
- unpin xblock-utils from 2.1.1
Also, add tests fixes and update the app version
@bryanlandia
Copy link
Contributor

Thank you for the PR. I'll take a look next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants