[ContainersPreview] Remove BorrowingSequence.first#598
Merged
lorentey merged 1 commit intoapple:mainfrom Mar 9, 2026
Merged
Conversation
This property is unnecessary; it was just demonstrating an old problem. It clashes with the classic `Collection.first`, and that renders invocations of that ambiguous in code that uses Collection types that also have a BorrowingSequence conformance.
tfpauly
approved these changes
Mar 9, 2026
tfpauly
left a comment
tfpauly
left a comment
There was a problem hiding this comment.
Thanks! This resolves conflicts on adoption.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This property is unnecessary; it was just demonstrating an old problem. It clashes with the classic
Collection.first, and that renders invocations of that ambiguous in code that uses Collection types that also have a BorrowingSequence conformance.If we end up adding
first/lastproperties onContainer, their type should probably beBorrow<Element>, unless they'd be restricted to copyable types.