Conversation
|
I have been running these tests on my Android CI for awhile, so should work fine. @marcprux, one elaboration to your official Android workflow that would be useful is to be able to specify multiple target triples to run the Android emulator with. That way, we could test the same Swift package against multiple Android API levels, which will be particularly useful once we roll out the new I take it that might require downloading multiple emulator images, so may be more work to set up, but some Swift packages, like |
|
Good idea. I've turned your comment into a new enhancement issue at swiftlang/github-workflows#226 so we can track it. |
lorentey
left a comment
There was a problem hiding this comment.
Nice! 👍
(I expect this will soon become another platform where we'll need to manually exclude specific swift versions as the package keeps bumping its minimum toolchain version. That is fine; but I'd like to rather declare the list of supported Swift versions in one place, rather than juggle exclusion lists per each platform. 😅)
|
This passed the new Android checks, as expected, don't know what's up with those pending linux checks. |
|
Hold off on merging till the official workflow is fixed, swiftlang/github-workflows#218. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
The error annotations problem has been fixed by swiftlang/github-workflows#234, @marcprux, can you rebase? |
|
@lorentey, one last run and we can get this in. |
.github/workflows/pull_request.yml
Outdated
| tests: | ||
| name: Test | ||
| uses: swiftlang/github-workflows/.github/workflows/[email protected].6 | ||
| uses: swiftlang/github-workflows/.github/workflows/[email protected].7 |
There was a problem hiding this comment.
I just synchronized the fork and now it is 0.0.7.
There was a problem hiding this comment.
Oops, I hadn't seen that. I've set them all to 0.0.8.
|
Ping @lorentey, can we get this in after updating that CI workflow tag? |
|
The dependabot PRs (#594, #595) already took care of bumping I see we'll need new (Those tests aren't that useful in their current form, but it seems like a good idea to keep them, in case we have time to grow them into something better.) |
I've blocked the test within |
With the recent advent of building and testing for Android, this PR adds Android to the CI testing matrix.
Tests are passing on Android, as can be seen in this trial run.
CC: @swiftlang/android-workgroup
Checklist