Fix formatting of nodes with no children #1351
Merged
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, this fixes an issue where an empty module turns into " \n".
HT154
approved these changes
Dec 5, 2025
Contributor
HT154
left a comment
HT154
left a comment
There was a problem hiding this comment.
Approving to unblock, but one little typo fix needed
pkl-formatter/src/test/kotlin/org/pkl/formatter/FormatterTest.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Jen Basch <[email protected]>
Member
Author
|
Thanks! I'm mostly sure this is correct but would also like @stackoverflow to take a look at this before merging. |
stackoverflow
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, this fixes an issue where an empty module turns into
\n.Closes #1348