Remove device id user #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove deviceId variable from ApphudInternal, making UserRepository the single source of truth. All access now goes through userRepository.getDeviceId()/setDeviceId() which delegates to UserDataSource (SharedPreferences). Updated ServiceLocator to initialize userRepository before RegistrationProvider and PurchaseBodyFactory, injecting it as a dependency. Removed direct storage.deviceId access from ApphudInternal. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Remove ApphudInternal.userId field and replace all references with userRepository.getUserId()/setUserId(). This makes UserRepository the single owner of userId state, consistent with the previous deviceId migration. Changes: - Remove `userId` field from ApphudInternal - Replace all ApphudInternal.userId reads with userRepository.getUserId() - Replace all ApphudInternal.userId/storage.userId writes with userRepository.setUserId() - Add getUserId()/setUserId() to RegistrationProvider for RegistrationBodyFactory access - Update tests to use userRepository instead of ApphudInternal.userId Co-Authored-By: Claude Opus 4.6 <[email protected]>
…userId Ensure userIdKey in SharedPreferences is always updated atomically when setCurrentUser() is called, including for temporary (fallback) users. Remove redundant userId side-effect from SharedPreferencesStorage.updateUser(). Previously userId was written from two places at different times, creating a desync window (e.g. on crash between writes). Now: - setCurrentUser() always calls dataSource.saveUserId(user.userId) - SharedPreferencesStorage.updateUser() no longer writes userIdKey - updateUserState() no longer needs a separate setUserId() call Co-Authored-By: Claude Opus 4.6 <[email protected]>
…getUserId() Replaced 3 places where userId was read from ApphudUser object obtained from userRepository with direct userRepository.getUserId() calls: - trackAnalytics: eliminated getCurrentUser() call entirely - updateUserId fallback chain: simplified getCurrentUser()?.userId - tryWebAttribution: extracted currentUserId variable for two usages Co-Authored-By: Claude Opus 4.6 <[email protected]>
aaudin90
force-pushed
the
RemoveDeviceIdUserId
branch
from
3ff608c to
23ec958
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves deviceId and userId ownership from ApphudInternal to UserRepository, eliminating state duplication and making UserRepository the single source of
truth for user identifiers.
Changes
UserRepository.getDeviceId()/setDeviceId(). All consumers (RequestManager, PurchaseBodyFactory, RegistrationBodyFactory, RegistrationProvider) obtain
deviceId through the repository
API Apphud.userId() delegates to the repository
indicating whether userId changed for listener notification
of calling getUserId() directly
Result