Skip to content

ZOOKEEPER-5011: Guard FileTxnSnapLog usage after close #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
seekskyworld wants to merge 1 commit into
base: branch-3.9
Choose a base branch
from
Open

ZOOKEEPER-5011: Guard FileTxnSnapLog usage after close #2346

seekskyworld wants to merge 1 commit into from
+54 −3

Conversation

@seekskyworld
Copy link

@seekskyworld seekskyworld commented Jan 14, 2026 •
edited
Loading

Issue: https://issues.apache.org/jira/browse/ZOOKEEPER-5011

Summary:

  • add a closed-state guard so stale references throw an IllegalStateException instead of NPEs
  • keep close idempotent and avoid marking the instance closed during truncateLog reopen
  • add coverage for save-after-close and idempotent close

Motivation:

  • improve diagnostics when stale ZooKeeperServer references hit FileTxnSnapLog after shutdown

Validation:

  • maven3\current\bin\mvn.cmd -pl zookeeper-server -Dtest=FileTxnSnapLogTest test

@seekskyworld seekskyworld force-pushed the fix/5011-filetxnsnaplog-closed branch from c83704c to ee9c131 Compare January 16, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@seekskyworld