Add logOnError option to ErrorReportValve #943
+119
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new logOnError option to ErrorReportValve.
When enabled, ErrorReportValve logs request information together with the
associated Throwable when generating an error page. This makes it easier
to trace the cause of errors that result in container-generated error pages.
The logOnError option is disabled by default to preserve the existing behavior
and avoid unexpected increases in log volume.
Changes included:
This change is fully backward-compatible when logOnError is not enabled.