Skip to content

Conversation

@Junuu
Copy link

@Junuu Junuu commented Jan 21, 2026

This PR adds a new logOnError option to ErrorReportValve.

When enabled, ErrorReportValve logs request information together with the
associated Throwable when generating an error page. This makes it easier
to trace the cause of errors that result in container-generated error pages.

The logOnError option is disabled by default to preserve the existing behavior
and avoid unexpected increases in log volume.

Changes included:

  • Add the logOnError attribute to ErrorReportValve
  • Log error details when an error page is generated and logOnError is enabled
  • Update valve.xml to document the new configuration option

This change is fully backward-compatible when logOnError is not enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant