[Feature] Enable variable support for the savepoint path#4282
Closed
CuteShaos wants to merge 1 commit intoapache:devfrom
Closed
[Feature] Enable variable support for the savepoint path#4282CuteShaos wants to merge 1 commit intoapache:devfrom
CuteShaos wants to merge 1 commit intoapache:devfrom
Conversation
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables variable support for Flink savepoint paths and fixes a bug where the getFinalSavepointDir method did not receive the processed path return value in version 2.1.6.
- Adds variable substitution support for job names and IDs in savepoint paths
- Restructures the savepoint path resolution logic to ensure proper processing order
- Introduces a new
processPathmethod to handle variable replacement
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CuteShaos
commented
Sep 2, 2025
Contributor
Author
CuteShaos
left a comment
There was a problem hiding this comment.
The matching result of the two writing styles is the same. The modification avoids useless captures and is more recommended.
The parameters jobName and jobId are not null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Enable variable support for saving point paths and resolve the bug in version 2.1.6 where getFinalSavepointDir did not receive a processPath return value, resulting in redundant calls and logical errors
What changes were proposed in this pull request
Issue Number: close #4278
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts