feat: support glob pattern matching in collect-on-failure paths

[wu-sheng]

Summary

• Add shell glob pattern support (*, ?, []) for paths in collect-on-failure config
• Patterns are expanded inside the container/pod via sh -c 'ls -d <pattern>' before copying
• Non-glob paths behave exactly as before (no behavior change for existing configs)
• Works for both Kind (kubectl exec) and Compose (docker exec) modes

Example usage

cleanup:
  collect:
    on: failure
    output-dir: /tmp/collect
    items:
      - namespace: default
        label-selector: app=oap
        paths:
          - /skywalking/logs*/     # matches logs, logs-oap, logs-ui, etc.
          - /tmp/*.hprof           # matches all heap dumps

Pattern rules (standard shell glob)

Pattern	Meaning	Example
*	Matches any characters within one directory level	/tmp/*.hprof matches /tmp/dump.hprof, /tmp/heap.hprof
?	Matches exactly one character	/var/log/app-?.log matches app-a.log, app-1.log
[...]	Matches one character in the set	/var/log/app-[abc].log matches app-a.log, app-b.log, app-c.log

Note: [0-9] matches a single digit only (e.g. app-1.log but not app-10.log). Use app-*.log to match multi-character suffixes.

Test plan

• Unit tests for containsGlob with various patterns
• Unit tests for expandPodGlob / expandContainerGlob passthrough (no glob)
• All existing tests pass
• Lint passes

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Adds shell-style glob expansion for cleanup.collect.on: failure paths, expanding patterns inside the target pod/container before copying files out, so users can collect multiple matching logs/dumps without enumerating them.

Changes:

• Expand glob patterns inside Kind pods via kubectl exec ... sh -c ... prior to kubectl cp.
• Expand glob patterns inside Compose containers via docker exec ... sh -c ... prior to docker cp.
• Add unit tests for containsGlob and no-glob passthrough for the expansion helpers.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
internal/components/collector/kind.go	Adds containsGlob + expandPodGlob and uses them when collecting pod files.
internal/components/collector/compose.go	Adds expandContainerGlob and uses it when collecting container files.
internal/components/collector/collector_test.go	Adds tests for glob detection and no-glob passthrough behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

This command is built via string interpolation and executed through util.ExecuteCommand (which runs bash -ec). Only the glob pattern is validated, but kubeConfigPath (and to a lesser extent container) are still unquoted, which can break when paths contain spaces and leaves room for shell-injection if config inputs are attacker-controlled. Also, 2>/dev/null || true suppresses real errors (e.g., permission denied / missing ls) and can incorrectly report “matched no files”; consider a safer expansion approach that distinguishes “no matches” from other failures and avoids shell parsing issues (e.g., robust quoting/escaping or passing args without an outer shell).