Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates write logic from client-side bulk processors to direct OAP Server-side streaming, moving away from the bulk write pattern to enable better control and observability metrics on the server side.
Key changes:
- Removed client-side bulk write processors for traces, streams, and measures
- Updated test cases to use direct StreamObserver pattern instead of bulk processors
- Modified PropertyStore usage to instantiate directly rather than through client methods
- Made AbstractWrite.build() method public to support direct streaming
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
ITTraceTest.java |
Replaced TraceBulkWriteProcessor with direct StreamObserver for trace writes |
ITBanyanDBStreamQueryTests.java |
Replaced StreamBulkWriteProcessor with direct StreamObserver for stream writes |
ITBanyanDBPropertyTests.java |
Changed property operations to use direct PropertyStore instantiation |
ITBanyanDBMeasureQueryTests.java |
Replaced MeasureBulkWriteProcessor with direct StreamObserver for measure writes |
TraceBulkWriteProcessor.java |
Removed entire bulk write processor implementation |
StreamBulkWriteProcessor.java |
Removed entire bulk write processor implementation |
MeasureBulkWriteProcessor.java |
Removed entire bulk write processor implementation |
BanyanDBClient.java |
Removed bulk processor factory methods and single write operations |
AbstractWrite.java |
Made build() method public and added getter for entityMetadata |
AbstractBulkWriteProcessor.java |
Removed entire abstract bulk write processor implementation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/test/java/org/apache/skywalking/banyandb/v1/client/ITTraceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/skywalking/banyandb/v1/client/ITTraceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/skywalking/banyandb/v1/client/ITBanyanDBStreamQueryTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/skywalking/banyandb/v1/client/ITBanyanDBMeasureQueryTests.java
Outdated
Show resolved
Hide resolved
wu-sheng
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the write logic to OAP Server, could have better control and set metrics for observing.
Part of related to apache/skywalking#13441