Skip to content

Move write logic to OAP Server.#101

Merged
wu-sheng merged 2 commits intomainfrom
remove-write-logic
Oct 13, 2025
Merged

Move write logic to OAP Server.#101
wu-sheng merged 2 commits intomainfrom
remove-write-logic

Conversation

@wankai123
Copy link
Member

@wankai123 wankai123 commented Oct 13, 2025

Move the write logic to OAP Server, could have better control and set metrics for observing.

Part of related to apache/skywalking#13441

@wankai123 wankai123 modified the milestone: 0.9.0 Oct 13, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates write logic from client-side bulk processors to direct OAP Server-side streaming, moving away from the bulk write pattern to enable better control and observability metrics on the server side.

Key changes:

  • Removed client-side bulk write processors for traces, streams, and measures
  • Updated test cases to use direct StreamObserver pattern instead of bulk processors
  • Modified PropertyStore usage to instantiate directly rather than through client methods
  • Made AbstractWrite.build() method public to support direct streaming

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
ITTraceTest.java Replaced TraceBulkWriteProcessor with direct StreamObserver for trace writes
ITBanyanDBStreamQueryTests.java Replaced StreamBulkWriteProcessor with direct StreamObserver for stream writes
ITBanyanDBPropertyTests.java Changed property operations to use direct PropertyStore instantiation
ITBanyanDBMeasureQueryTests.java Replaced MeasureBulkWriteProcessor with direct StreamObserver for measure writes
TraceBulkWriteProcessor.java Removed entire bulk write processor implementation
StreamBulkWriteProcessor.java Removed entire bulk write processor implementation
MeasureBulkWriteProcessor.java Removed entire bulk write processor implementation
BanyanDBClient.java Removed bulk processor factory methods and single write operations
AbstractWrite.java Made build() method public and added getter for entityMetadata
AbstractBulkWriteProcessor.java Removed entire abstract bulk write processor implementation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@wu-sheng wu-sheng added this to the 0.9.2 milestone Oct 13, 2025
@wu-sheng wu-sheng merged commit 35eb8b8 into main Oct 13, 2025
10 of 12 checks passed
@wu-sheng wu-sheng deleted the remove-write-logic branch October 13, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants