Ranger -5587 modified && condition to OR to resolve the issue of definition id #943
Open
abhiishek26 wants to merge 1 commit into
Open
Ranger -5587 modified && condition to OR to resolve the issue of definition id #943abhiishek26 wants to merge 1 commit into
abhiishek26 wants to merge 1 commit into
Conversation
…nchronization in put /definitions/{id}
Contributor
|
can you add a Junit test if possible ? |
mneethiraj
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
synchronization in put /definitions/{id}
What changes were proposed in this pull request?
The PUT api http://localhost:6080/service/plugins/definitions/{id} is not throwing error when different id is passed from url and json payload , the issue is because in of a && condition updateServiceDef in ServiceREST which should have been OR ,I have changed it . On changing the And condition to or it is proprly throwing error as expected .