Conversation
…ted fine-tuning the code to work with more and more of the test-cases.
…er how to decode the temporal values.
…th my Siemens S7 OPC-UA Server.
…ning # Conflicts: # pom.xml
|
seems like you did not adjust the Golang version? Why was it required to go to a manual field? Sometimes it is a bit hard to find the static helper in the mega diff :D |
|
In order to read some of the time fields I needed to add this alternative ... but yeah ... didn't know we had an OPC-UA driver in Go ... sorry for that (I stopped building Go as it takes for ever every time) |
|
no worries, the go build where broken due to the invoker messup for a while so maybe that didn't jump directly to the eye. Since I repaired it red should really mean build fail 🗡️ |
splatch
left a comment
splatch
left a comment
There was a problem hiding this comment.
Some of changes are unrelated to opc-ua. Some other changes affect existing logic. Please revisit these.
| biConsumer.accept(message, e); | ||
| // Use the original payload rather than the transformed message, | ||
| // as the error consumer expects the original message type. | ||
| biConsumer.accept(payload, e); |
There was a problem hiding this comment.
Error handlers are "global", hence by introducing this change you may break some drivers in situations which we do not test.
| ['false', 'true' BinaryExtensionObjectWithMask | ||
| [implicit int 32 bodyLength 'body == null ? 0 : body.lengthInBytes'] | ||
| [simple ExtensionObjectDefinition('extensionId') body] | ||
| [manual ExtensionObjectDefinition body 'STATIC_CALL("parseExtensionObjectBody", readBuffer, extensionId, bodyLength)' 'STATIC_CALL("serializeExtensionObjectBody", writeBuffer, body)' 'body == null ? 0 : body.lengthInBits'] |
There was a problem hiding this comment.
I understand reason for the change, but better move needed logic and UnknownExtensionObject to mspec, so it will be portable across languages.
| * Stores the raw body bytes so they can be interpreted later based on context | ||
| * (e.g., the tag's dataType hint). | ||
| */ | ||
| public class UnknownExtensionObject extends ExtensionObjectDefinition { |
There was a problem hiding this comment.
Please move this definition to mspec.
3 participants
Please review :-)
These were changes needed to get the manual test to work with the OPC-UA server of my S7-1500 device.