[core] Fix LookupMergeFunction to use sequence.field for picking high level records #7221
+225
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #7220
When
sequence.fieldis configured,LookupMergeFunction.pickHighLevel()should select the record with the highest sequence value instead of the lowest level number.Problem
Previously,
pickHighLevel()only compared level numbers:This could lead to incorrect results when out-of-order data arrives:
The old logic would pick L1 (level 1 < level 2), but the correct behavior should pick L2 (sequence 8 > 7).
Changes
sequenceComparatorfield toLookupMergeFunctionpickHighLevel()to use sequence comparator when availablegetResult()to sort records by sequence before adding to merge functionsequenceComparatorwhen user-defined sequence field is configured, preserving original behavior whensequence.fieldis not setTests
Added 3 test cases:
testSequenceFieldWithMultipleLevels- verifies sequence.field is used correctlytestWithoutSequenceFieldPreservesOriginalBehavior- verifies backward compatibilitytestSequenceFieldWithDescendingSortOrder- verifies descending sort order worksImpact
Only affects
changelog-producer = lookupwithsequence.fieldconfigured. No impact on:sequence.field