Improved : Rewrites FlexibleMapAccessorTest (OFBIZ-13345)#960
Open
gtchaboussie wants to merge 1 commit intoapache:trunkfrom
Open
Improved : Rewrites FlexibleMapAccessorTest (OFBIZ-13345)#960gtchaboussie wants to merge 1 commit intoapache:trunkfrom
gtchaboussie wants to merge 1 commit intoapache:trunkfrom
Conversation
- Rewrites the FlexibleMapAccessorTest in groovy - Explodes the previous big test in several test cases, a cases for each feature of the FMA. - Removes some of the testing lines that were not relevant : - Testing that a FMA in a set is correctly contained - Testing a FSE instance in this class. FSE has its own test cases. - Some of the lines were repeated, only with the two compared objects inverted. - Creates a dedicated class for the utility test map.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks: