Skip to content

Fixed: sendInvoicePerEmail fails with MissingMethodException (OFBIZ-13388) #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arashpreet0011 wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fixed: sendInvoicePerEmail fails with MissingMethodException (OFBIZ-13388) #1131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ...counting/src/main/groovy/org/apache/ofbiz/accounting/invoice/InvoiceServicesScript.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,13 +326,13 @@ Map cancelInvoice() {
* @return Success response
*/
Map sendInvoicePerEmail() {
Map ctx = [*: parameters,
xslfoAttachScreenLocation: 'component://accounting/widget/AccountingPrintScreens.xml#InvoicePDF',
bodyParameters: [invoiceId: parameters.invoiceId,
userLogin: parameters.userLogin,
other: parameters.other]] //to print in 'other currency'
Map emailParams = dispatcher.getDispatchContext()
.makeValidContext([*: parameters,
xslfoAttachScreenLocation: 'component://accounting/widget/AccountingPrintScreens.xml#InvoicePDF',
bodyParameters: [invoiceId: parameters.invoiceId,
userLogin: parameters.userLogin,
other: parameters.other] //to print in 'other currency'
])
.makeValidContext('sendMailFromScreen', 'IN', ctx)
dispatcher.runAsync('sendMailFromScreen', emailParams)
return success(label('AccountingUiLabels', 'AccountingEmailScheduledToSend'))
}
Expand Down Expand Up @@ -563,7 +563,7 @@ Map addTaxOnInvoice() {
addTaxMap.itemAmountList << totalAmount
addTaxMap.itemPriceList << it.amount
addTaxMap.itemQuantityList << it.quantity
addTaxMap.itemShippingList << BigDecimal.ZERO
addTaxMap.itemShippingList << 0
Copy link
Copy Markdown

@vyasdevanshu vyasdevanshu May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is out of context of the ticket fix.
Is there any specific reason to include this in the current changes?

}
if (!addTaxMap.itemProductList) {
return error(label('AccountingUiLabels', 'AccountingTaxProductIdCannotCalculate'))
Expand Down