drivers/sensors: sensor bug fix - part 1 #17824
Open
+54
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otpvondoiats
requested review from
Donny9,
jerpelea and
xiaoxiang781216
as code owners
github-actions
bot
added
Area: Sensors
Otpvondoiats
force-pushed
the
lk_fix_direct_flag
branch
from
dd60fe3 to
6d1bebc
Compare
github-actions
bot
added
Area: OS Components
The logic for obtaining the info and configuring the user buffer have been optimized. Signed-off-by: dongjiuzhu1 <[email protected]>
Fixes the issue of cross-core IPC being triggered when using O_DIRECT in non-cross-core scenarios. Signed-off-by: likun17 <[email protected]>
…rmation. When the local core is a virtual sensor, attempt to retrieve information from a remote core. Signed-off-by: likun17 <[email protected]>
Otpvondoiats
force-pushed
the
lk_fix_direct_flag
branch
from
6d1bebc to
d510572
Compare
jerpelea
changed the title
jerpelea
approved these changes
Jan 12, 2026
Contributor
jerpelea
left a comment
jerpelea
left a comment
There was a problem hiding this comment.
please add "drivers/sensors:" in front of commit title
acassis
reviewed
Jan 12, 2026
| } | ||
|
|
||
| if (lower->ops->open) | ||
| if ((filep->f_oflags & O_DIRECT) == 0 && lower->ops->open) |
Contributor
There was a problem hiding this comment.
Please include comment explaining the idea. Why do you need to check if O_DIRECT flag is set?
| } | ||
|
|
||
| if ((filep->f_oflags & O_DIRECT) == 0) | ||
| if (filep->f_oflags & O_RDOK) |
Contributor
There was a problem hiding this comment.
Also it is good to have a comment before this block
Contributor
Author
|
wait for #17837 and apache/nuttx-apps#3312 |
linguini1
requested changes
Jan 12, 2026
Contributor
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
Ideally this could be three separate PRs since the commits seem unrelated.
We have conducted tests on the following platforms
Can you please provide more information about your testing? What did you test on the platforms, how do you know the behaviour is correct, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Cross-core direct connection and cross-core information retrieval
Testing
We have conducted tests on the following platforms:
Simulator - single core:pass
BES Platform - multi-core:pass;