net/pkt: Fix coverity issue #17520
net/pkt: Fix coverity issue #17520
Conversation
The value ret is overwritten after being assigned a value. Signed-off-by: zhangshuai39 <[email protected]>
github-actions
bot
added
Area: Networking
| { | ||
| nerr("ERROR: Unsupported socket type: %d\n", psock->s_type); | ||
| ret = -ENOSYS; | ||
| return -ENOSYS; |
There was a problem hiding this comment.
This is not just a Coverity issue. Your update has altered the behavior of this Func. You need to provide a more detailed analysis to explain the impact.
There was a problem hiding this comment.
The change does seem reasonable: if the socket type is unsupported then it seems reasonable that we should not proceed with the rest of the function.
However, I agree that the PR description and commit log need to be updated. Rather than "Fix coverity issue" I recommend something like: "net/pkt_recvmsg(): Fix error handling in case of unsupported socket types". You can include "Found by Coverity" in the PR description and log message.
Also I recommend to update the function's docstring to indicate that psock must be of type SOCK_RAW. Currently that's not documented.
Have you tested the network code in some way to exercise this code path?
simbit18
requested review from
acassis,
anchao,
jerpelea,
linguini1 and
raiden00pl
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
Please include an explanation of what test you performed and the results in your testing section. "self-test" isn't a sufficient description.
8 participants
Summary
The value ret is overwritten after being assigned a value.
Impact
Scenario of receiving a PKT socket of type non-SOCK_RAW
Testing
It has passed self-testing in sim & qemu-goldfish-armeabi-v7a-ap