-
Notifications
You must be signed in to change notification settings - Fork 985
[KYUUBI #7192] Fix filestatus not cached #7191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cache version 2 cache ut change ut
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7191 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 696 697 +1
Lines 43530 43607 +77
Branches 5883 5898 +15
======================================
- Misses 43530 43607 +77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@pan3793 could u pls take a look at it |
...or-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/read/HiveFileStatusCache.scala
Show resolved
Hide resolved
...or-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/read/HiveFileStatusCache.scala
Outdated
Show resolved
Hide resolved
5b7354e to
9f2168c
Compare
7950d8b to
b5aaec0
Compare
|
Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag! Thank you for using Kyuubi! |

The previous filestatus will not be cached, as its source hivetable will be created every time, and the filestatus will also be created, resulting in different client IDs for the cached object's key, leading to cache invalidation.
It can cause two problems:
Why are the changes needed?
Improve perfomance.
How was this patch tested?
UT and spark sql query.
Was this patch authored or co-authored using generative AI tooling?
No.