Do not require LIBCMARKDIR when GFM is unused#100
Open
Herrtian wants to merge 1 commit intoapache:masterfrom
Open
Do not require LIBCMARKDIR when GFM is unused#100Herrtian wants to merge 1 commit intoapache:masterfrom
Herrtian wants to merge 1 commit intoapache:masterfrom
Conversation
Herrtian
force-pushed
the
fix-libcmarkdir-without-gfm
branch
from
c35f0e4 to
0f647af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83.
This defers the default cmark path handling until the Pelican subprocess environment is built. If the packaged cmark path exists, it is still passed through as before. If it does not, an existing
LIBCMARKDIRin the environment is left alone, and non-GFM builds no longer fail while importingbuildsite.py.I also dropped the dummy
LIBCMARKDIRfrom the postrun test so the no-GFM case is covered.Checked with:
python3 -m py_compile bin/buildsite.py plugins/gfm.pycd tests/postrun && unset LIBCMARKDIR && bash runtest.sh