verify-action-build: widen source-commit window + prefer exact tag match#821
Merged
potiuk merged 1 commit intoapache:mainfrom May 8, 2026
Merged
Conversation
resolve_source_commit's +1min cutoff missed release-please-style
orphan tags whose master "release vX.Y.Z" commit lands a few
seconds *after* the tag is published. benchmark-action/
github-action-benchmark v1.22.1 hits this: orphan tag at
10:36:23, master release commit at 10:37:24 — 1 second past the
cutoff. Resolver fell back to v1.22.0's release commit, rebuild
produced v1.22.0's dist, JS-build-verification flagged
"DIFFERENCES DETECTED" against v1.22.1's published dist.
Search ±2h around the tag's published_at and disambiguate by
exact tag-name match in the commit message ("release v1.22.1"
matches tag v1.22.1, also matches "release 1.22.1" without the
v). Falls back to the existing generic release-marker on miss.
This was referenced May 7, 2026
dave2wave
approved these changes
May 7, 2026
Member
dave2wave
left a comment
dave2wave
left a comment
There was a problem hiding this comment.
Looks like it can handle multiple versions released in the same 4 hour window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_source_commit'spublished_at + 1mincutoff missed release-please-style orphan tags where the masterrelease vX.Y.Zcommit lands seconds after the tag is published. benchmark-action/github-action-benchmark v1.22.1 (support benchmark-action/github-action-benchmark #805) hits this: tag published at10:36:23Z, master release commit at10:37:24Z— 1 second past the old cutoff. Resolver fell back to v1.22.0's release commit; rebuild produced v1.22.0's dist; verification reported "DIFFERENCES DETECTED" against v1.22.1's published dist.±2haround the anchor and add a strong-preference match on the exact tag name in the commit message (release v1.22.1matches tagv1.22.1; also matchesrelease 1.22.1without thevprefix). Falls back to the existing generic release-marker on miss.test_release_lookup.pycovering: orphan-tag-pushed-before-master-release; multiple "release X" commits in window (exact match wins); release-please's no-v-prefix message variant; release-marker fallback; empty-commit-list and missing-release edge cases.Test plan
uv run pytest utils/tests/— 229/229.prek run --all-filesclean.verify-action-build benchmark-action/github-action-benchmark@52576c92…(PR support benchmark-action/github-action-benchmark #805's SHA) — was failing on origin/main; with the fix the source-detached fallback resolves to67cf262e8c79("release v1.22.1") and all 16src/*.jsfiles are byte-identical. Exit 0.Generated-by Claude Code.