allowlist: remove browser-actions/setup-geckodriver and /setup-firefox#818
Merged
potiuk merged 1 commit intoapache:mainfrom May 7, 2026
Merged
allowlist: remove browser-actions/setup-geckodriver and /setup-firefox#818potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
Contributor
|
This LGTM, not 100% sure what the failure is about though. |
Member
Author
It couldn't determine what action was added, which makes sense since no action was added :) I'm OK with that: I'd rather have an incorrectly-red test in this case then an incorrectly-green one when the action is not recognized for some reason. |
potiuk
approved these changes
May 7, 2026
Member
I can ask my agent to fix it :) |
3 tasks
Member
|
#820 -> my aagent did good job :) |
Member
As Tapestry was the only one using them, and they moved away from it. apache#813 apache/tapestry-5#58
potiuk
added a commit
to raboof/infrastructure-actions
that referenced
this pull request
May 7, 2026
The --from-pr branch fails for removal-only PRs (e.g. apache#818) because extract_action_refs_from_diff correctly returns no refs when a PR only removes entries — there's nothing new to verify. The CLI treated that as a fatal error. Distinguish the two empty-result cases: a diff-fetch failure still exits 1, while a successfully-fetched diff with no added refs exits 0 with a "nothing to verify" message.
potiuk
force-pushed
the
remove-setup-firefox
branch
from
4c7fc11 to
f57927d
Compare
Member
|
OH... actually I could rebase it - green now. Merging :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Tapestry was the only one using them, and they
moved away from it.
#813 apache/tapestry-5#58