Conversation
Bumps [graalvm/setup-graalvm](https://github.com/graalvm/setup-graalvm) from 1.5.2 to 1.5.3. - [Release notes](https://github.com/graalvm/setup-graalvm/releases) - [Commits](graalvm/setup-graalvm@60c2672...bef4b0e) --- updated-dependencies: - dependency-name: graalvm/setup-graalvm dependency-version: 1.5.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
3 tasks
Member
|
Reviewed all 7 "unverified download" findings — all 7 are false positives, surfacing three distinct gaps in our JS download / verification heuristic:
Fix in flight at #830 — three small heuristic tightenings. With it applied, the action passes ( No upstream issue/PR needed — graalvm/setup-graalvm's verification chain is sound (downloads happen via helpers, then |
Member
|
The #830 fix with verified download heuristics + manual review of the changes done -> looks good to merge. |
potiuk
approved these changes
May 9, 2026
potiuk
deleted the
dependabot/github_actions/dot-github/actions/for-dependabot-triggered-reviews/graalvm/setup-graalvm-1.5.3
branch
potiuk
added a commit
that referenced
this pull request
May 11, 2026
…tives graalvm/setup-graalvm v1.5.3 (PR #817) flagged 7 "unverified downloads" all of which were false positives: * 2x http.get(url, { accept: 'application/json' }) followed by JSON.parse — JSON metadata calls, not binary downloads. * 1x async function downloadTool(...) — function definition that happens to start with the helper's name. * 4x downloads (across gds.ts/utils.ts) where verification IS in the same file via createHash('sha256') and a custom calculateSHA256 helper, but the regex required crypto. createHash (with module prefix) and missed the bare imported form + custom helper names. Three fixes: 1. Add ``accept: 'application/json'`` (single- or double-quoted) as a data-parse marker. An HTTP call asking for JSON in its own request headers is data, not bytes. 2. Skip lines that look like function definitions in the download-pattern scanner. ``function name(``, ``async function name(``, ``export default async function name(`` and ``function* name(`` all match the new ``_JS_FUNCTION_DEFINITION_RE`` and are excluded. 3. Recognize bare ``createHash('sha…')`` and the conventional ``calculateSHA[256|512|...]`` / ``calculateChecksum`` / ``verifyHash`` / ``computeChecksum`` helper names as verification. 12 new tests pin each fix. Re-running verify-action-build against graalvm/setup-graalvm@bef4b0e9 (the v1.5.3 SHA): exit 0; the 6 remaining findings are recognized as "verification present in file" and reported as warnings rather than failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps graalvm/setup-graalvm from 1.5.2 to 1.5.3.
Release notes
Sourced from graalvm/setup-graalvm's releases.
Commits
bef4b0eBump version to1.5.3.827e827Regenerate dist/ files.71fb2abRunnpm audit fix.e2605aaBump the all group with 3 updatesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)