verify-action-build: skip lock-file check for empty package.json#816
Merged
potiuk merged 1 commit intoapache:mainfrom May 6, 2026
Merged
Conversation
The check already skips bare-config pyproject.toml and require-less
go.mod. Mirror that for package.json with no dependencies — the case
that release-please-style bundled action tags ship (a self-contained
index.js next to a minimal {"type": "module"}). browser-actions/
setup-firefox v1.7.2 (PR apache#813) hits this; v1.7.0 / v1.7.1 were
approved before the lock-file check landed.
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
analyze_lock_filesalready skips dependency-lesspyproject.tomland require-lessgo.mod. Add the same skip forpackage.jsondeclaring nodependencies/devDependencies/peerDependencies/optionalDependencies/bundled[D|d]ependencies.browser-actions/setup-firefox@v1.7.2) and the same class of release-please-style bundled tags that ship a minimalpackage.json+ self-containedindex.js."{}"package.json fixtures now hit the no-deps skip.Test plan
uv run pytest utils/tests/— 221/221.prek run --all-filesclean.verify-action-build --from-pr 813returns exit 0 with the fix;Lock file presence: ✓.Generated-by Claude Code.