Conversation
|
thanks @namanagraw for reporting . Changes lgtm. thanks for providing the validation report also. Need to improve UT and please track UT's once after this commit. |
33e7935 to
e9c7d98
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Jetty web server dependency from version 9.4.50.v20221201 to 10.0.1 and updates the servlet API version from 3.1.0 to 4.0.1. The upgrade requires updating the request logging implementation to use Jetty 10's new API.
- Updated Jetty version from 9.4.50 to 10.0.1 in Maven dependencies
- Updated javax.servlet-api from 3.1.0 to 4.0.1 to match Jetty 10 requirements
- Refactored request logging to use Jetty 10's new CustomRequestLog and RequestLogWriter APIs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pom.xml | Updates Jetty and servlet API version properties |
| WebServer.scala | Migrates from deprecated NCSARequestLog to new CustomRequestLog implementation |
Comments suppressed due to low confidence (1)
server/src/main/scala/org/apache/livy/server/WebServer.scala:101
- The
setExtended(false)method call was removed during the migration to CustomRequestLog, but this configuration might be needed. In Jetty 10, extended logging is controlled by the log format string passed to CustomRequestLog constructor. Verify that the NCSA_FORMAT provides the desired level of logging detail.
requestLogWriter.setTimeZone("GMT")
|
This pull request has been automatically marked as stale because it has had no activity for at least 3 months. If you are still working on this change or plan to move it forward, please leave a comment or push a new commit so we know to keep it open. Otherwise, this PR will be closed automatically in about one month. Thank you for your contribution to Apache Livy! |
What changes were proposed in this pull request?
How was this patch tested?
Tested in local
