IGNITE-28512 Message serializer for PartitionKey#13084
Open
Vladsz83 wants to merge 18 commits intoapache:masterfrom
Open
IGNITE-28512 Message serializer for PartitionKey#13084Vladsz83 wants to merge 18 commits intoapache:masterfrom
Vladsz83 wants to merge 18 commits intoapache:masterfrom
Conversation
Vladsz83
changed the title
shishkovilja
reviewed
May 7, 2026
| * Management task result. | ||
| */ | ||
| public class VisorTaskResult<R> extends IgniteDataTransferObject { | ||
| public class VisorTaskResult<R> implements Serializable { |
Contributor
There was a problem hiding this comment.
Why Serializable, not Message?
Contributor
Author
There was a problem hiding this comment.
Because the thin client protocol doesnt support messages. And the realisation is far beyond this ticket.
Contributor
There was a problem hiding this comment.
Should we remove @Order from fields then?
shishkovilja
reviewed
May 7, 2026
| this.clientRouterNodeId = node.isClient() ? node.id() : null; | ||
|
|
||
| attrs = Collections.singletonMap(ATTR_NODE_CONSISTENT_ID, consistentId); | ||
| public static <PK, CK extends PK, V> Map<CK, V> downcast(Map<PK, V> m) { |
Contributor
There was a problem hiding this comment.
We already have several downcast and upcast methods in ServerImpl, TcpDiscoveryImpl. May be we should move them to IgniteUtils and merge (if possible).
Contributor
Author
There was a problem hiding this comment.
It is only about TcoDiscoveryNode and ZookeeperNode which might be removed in future with zookeper discovery removal. With zookeper removal, the upcast and downcast would be even rarer.
Possible compatibility issues. Please, check rolling upgrade casesThis PR modifies protected classes (with Order annotation). Affected files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see tabPR Checkat TC.Bot - Instance 1 or TC.Bot - Instance 2)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.