Davis/ordering fields as precombine#570
Draft
Davis-Zhang-Onehouse wants to merge 2 commits intoapache:mainfrom
Draft
Davis/ordering fields as precombine#570Davis-Zhang-Onehouse wants to merge 2 commits intoapache:mainfrom
Davis-Zhang-Onehouse wants to merge 2 commits intoapache:mainfrom
Conversation
xushiyan
reviewed
Mar 31, 2026
| /// Initialize env_logger exactly once for the lifetime of the loaded shared library. | ||
| /// | ||
| /// Reads RUST_LOG from the environment at the time the first FileGroupReader is created. | ||
| /// Example: RUST_LOG=hudi_core=debug enables all hudi-core debug logs. |
Member
There was a problem hiding this comment.
can we split the changes into separate PR pls? the title suggests it's about support "ordering fields" as alias, so let's separate out logger changes?
Author
There was a problem hiding this comment.
sorry, all these PRs are still WIP, please ignore all PRs under my name.
xushiyan
reviewed
Mar 31, 2026
| let get_result = if matches!(self, Self::PrecombineField) { | ||
| get_result.or_else(|_| { | ||
| configs | ||
| .get("hoodie.table.ordering.fields") |
Member
There was a problem hiding this comment.
we need to add a new enum item called OrderingFields as a table config, and mark PrecombineField as deprecated. Then all applicable callers resolve ordering fields first then fall back to precombine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How are the changes test-covered