HIVE-28655: Implement HMS Related Drop Stats Changes (Part2) COL_STATS_ACCURATE related changes #6198
+267
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…AT_ACCURATE After Dropping
… COL_STATS_ACCURATE related changes
DanielZhu58
force-pushed
the
HIVE-28655-part2
branch
from
6bed69f to
61539a6
Compare
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
|
dengzhhu653
reviewed
Jan 15, 2026
| } | ||
|
|
||
| // Serialize the map into a new JSON string | ||
| String updatedValue = mapper.writeValueAsString(statsMap); |
Member
There was a problem hiding this comment.
use StatsSetupConst.removeColumnStatsState?
soumyakanti3578
requested changes
Jan 15, 2026
Contributor
soumyakanti3578
left a comment
soumyakanti3578
left a comment
There was a problem hiding this comment.
Added a few comments here, but I also noticed that I had reviewed the earlier version of this PR: #5790
Please go through the review comments there too.
Also it would be nice to go through the sonar report and fix the ones that make sense. For example, there are many reports on code conventions that you should incorporate to improve maintainability and consistency.
...tore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
Show resolved
Hide resolved
...tore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
Show resolved
Hide resolved
...tore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
Show resolved
Hide resolved
...tore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
Show resolved
Hide resolved
...tore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We need a way to drop the stats associated with the table/partition and its columns.
This can help a lot in migration or replication where the stats data take huge time to copy.
Particularly when the table is partitioned, we have stats rows for each table, partition, column combination, which can get huge when the number of partitions is huge.
This is the HMS side changes.
This is the part2 with the parameter COL_STATS_ACCURATE related changes.
Why are the changes needed?
This can give the users potential options to clear the unnecessary stats.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual tests and unit tests.